[FStab Handling] Clean up process running by using lambdas
ClosedPublic
Actions

Authored by broulik on Jan 4 2018, 12:16 PM.

Details

Reviewers

Commits

R245:967dc53dc9a5: [FStab Handling] Clean up process running by using lambdas

Summary

Encapsulates the QProcess* into the job it's supposed to be doing without storing it as a member and polluting state when multiple actions are requested simultaneously.

CCBUG: 388499

Test Plan

Added a random mount to my fstab, tried to mount it, still showed a nice error in Dolphin.
Verified that the QProcess is deleted after the task is completed

Dunno if that actually fixes the bug but the way the member variable is treated (never null'd and occasionally overwritten) looked fishy.

Diff Detail

Repository

R245 Solid

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.Jan 4 2018, 12:16 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJan 4 2018, 12:16 PM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

broulik requested review of this revision.Jan 4 2018, 12:16 PM

davidedmundson accepted this revision.Apr 24 2018, 3:07 PM

This revision is now accepted and ready to land.Apr 24 2018, 3:07 PM

Closed by commit R245:967dc53dc9a5: [FStab Handling] Clean up process running by using lambdas (authored by broulik). · Explain WhyMay 16 2018, 12:38 PM

This revision was automatically updated to reflect the committed changes.

Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. · View Herald TranscriptMay 16 2018, 12:38 PM

Revision Contents
Changeset List

			Path	Packages
M			src/solid/devices/backends/fstab/fstabhandling.h (9 lines)
M			src/solid/devices/backends/fstab/fstabhandling.cpp (29 lines)
M			src/solid/devices/backends/fstab/fstabstorageaccess.h (3 lines)
M			src/solid/devices/backends/fstab/fstabstorageaccess.cpp (42 lines)