Differential D9612

Don't show "Edit Application..." action for non-app services.
ClosedPublic
Actions

Authored by hein on Jan 2 2018, 4:28 PM.

Details

Reviewers
broulik
davidedmundson
Group Reviewers
Plasma
Commits
R119:16c97a1645ae: Don't show "Edit Application..." action for non-app services.
R120:fcb86569c0db: Don't show "Edit Application..." action for non-app services.
Summary

When the code was refactored to show this action also for runner
matches, proper care wasn't taken to test for this, so the action
was shown for document matches as well. It's not safe to use for
docs currently (which should probably be fixed in
KPropertiesDialog) and at any rate isn't meant to be a generic
editing feature as per the action name.

BUG:388340

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Jan 2 2018, 4:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 2 2018, 4:28 PM
hein requested review of this revision.Jan 2 2018, 4:28 PM
hein updated this revision to Diff 24604.Jan 2 2018, 4:36 PM

Don't go KService for anything but the services runner.

davidedmundson accepted this revision.Jan 2 2018, 4:37 PM
This revision is now accepted and ready to land.Jan 2 2018, 4:37 PM
hein updated this revision to Diff 24606.Jan 2 2018, 4:38 PM

Fix return statement.

Closed by commit R119:16c97a1645ae: Don't show "Edit Application..." action for non-app services. (authored by hein). · Explain WhyJan 2 2018, 4:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24607

View Options

applets/kicker/plugin/actionlist.cpp

Loading...
View Options

applets/kicker/plugin/runnermatchesmodel.cpp

Loading...