Differential D9573

Document "ReadyButton.qml"
ClosedPublic
Actions

Authored by amankumargupta on Dec 31 2017, 6:00 AM.

Tags

Subscribers

KDE Edu, jjazeix, GCompris: Improvements

Details

Reviewers

Group Reviewers

GCompris: Improvements

Maniphest Tasks

T7585: Document "ReadyButton.qml"

Summary

Documented src/core/ReadyButton.qml

Diff Detail

Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

amankumargupta created this revision.Dec 31 2017, 6:00 AM

Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 31 2017, 6:00 AM

Restricted Application added a subscriber: KDE Edu. · View Herald Transcript

amankumargupta requested review of this revision.Dec 31 2017, 6:00 AM

amankumargupta added a task: T7585: Document "ReadyButton.qml".Dec 31 2017, 6:02 AM

jjazeix added inline comments.Dec 31 2017, 4:41 PM

src/core/ReadyButton.qml
25 ↗	(On Diff #24511)	iAmReady
69 ↗	(On Diff #24511)	no need to comment internal properties, only the ones exposed in the API
75 ↗	(On Diff #24511)	comment not useful, visible is self explained
86 ↗	(On Diff #24511)	internal property (same for the ones below)

Removed all internal property comments.

amankumargupta updated this revision to Diff 24530.Dec 31 2017, 5:03 PM

Added missing space in a comment.

jjazeix accepted this revision.Dec 31 2017, 6:02 PM

This revision is now accepted and ready to land.Dec 31 2017, 6:02 PM

committed, thank you :)

Revision Contents
Changeset List

			Path	Packages
M			src/core/ReadyButton.qml (29 lines)

Diff 24529

src/core/ReadyButton.qml

Loading...