Differential D957

Fix userActivity signal when running in kwin_wayland
AbandonedPublic
Actions

Authored by graesslin on Feb 17 2016, 6:44 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

This one is strange: the lambda slot is not invoked when
Qt::QueuedConnection is used on Wayland, but on X11 it works just
fine. On Wayland it also works if the context object is changed from
this to the sender.

Unfortunately I couldn't figure out why that's the case.

Diff Detail

Repository
R133 KScreenLocker
Branch
fix-user-activity-wayland
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin updated this revision to Diff 2332.Feb 17 2016, 6:44 AM
graesslin retitled this revision from to Fix userActivity signal when running in kwin_wayland.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 17 2016, 6:44 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ivan added a subscriber: ivan.Mar 26 2016, 12:07 PM
ivan added inline comments.
ksldapp.cpp
612

This is equivalent to connect(m_lockWindow, signal-ptr, lambda) - adding m_lockWindows as the third argument basically lies that we are using the 'safe' version of connect.

graesslin added inline comments.Apr 4 2016, 12:17 PM
ksldapp.cpp
612

no it's not the same. It's using Qt::QueuedConnection instead of Qt::AutoConnection.

Revision Contents
Changeset List

PathPackages
Mksldapp.cpp (2 lines)

Diff 2332

View Options

ksldapp.cpp

Loading...