Workaround problems with Qt::QueuedConnection
ClosedPublic
Actions

Authored by graesslin on Apr 4 2016, 12:37 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

For unknown reasons our signals with Qt::QueuedConnection are not
delivered with Qt 5.6 if the context object is this (KSldApp instance).

If we use a different context object (e.g. the sender) it works.

The lack of signals not working triggered quite a few bugs, like

BUG: 361008
BUG: 361007

Repository

R133 KScreenLocker

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin retitled this revision from to Workaround problems with Qt::QueuedConnection.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Bah, but okay. :/

This revision is now accepted and ready to land.Apr 4 2016, 2:01 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/ksldtest.cpp (3 lines)
M			ksldapp.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3126	bd17972		Apr 4 2016, 12:37 PM	★	★
Diff 2	3129	33165b2	rKSCREENLOCKERe9984e21b798a0894e49dc74489a8fc7c2c2347d	Apr 4 2016, 4:49 PM	★	★