Differential D9471

Use "focused" instead of "visible" and "hidden" in Konsole notifications
ClosedPublic
Actions

Authored by ahmadsamir on Dec 21 2017, 5:22 PM.

Details

Reviewers
hindenburg
Commits
R319:3e7981a2917d: Use "focused" instead of "visible" and "hidden" in notifications
Summary

Acting on the suggestion in [1] BUG: 350001, I've replaced "visible" and "hidden" in konsole.knotifyrc with "focused"; this indeed sounds like a better, more clear wording.

(If there's a different procedure to handling files with translated strings like .knotifyrc I couldn't find it... ).

[1]https://bugs.kde.org/show_bug.cgi?id=350001

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Dec 21 2017, 5:22 PM
Restricted Application added a project: Konsole. · View Herald TranscriptDec 21 2017, 5:22 PM
Restricted Application added a subscriber: Konsole. · View Herald Transcript
ahmadsamir requested review of this revision.Dec 21 2017, 5:22 PM
hindenburg accepted this revision.Dec 23 2017, 5:35 PM

Looks fine thanks - new strings and some other BC changes can only go into master branch (not the Applications/XX.XX)

This revision is now accepted and ready to land.Dec 23 2017, 5:35 PM
Closed by commit R319:3e7981a2917d: Use "focused" instead of "visible" and "hidden" in notifications (authored by hindenburg). · Explain WhyDec 23 2017, 5:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdesktop/konsole.notifyrc (42 lines)

Diff 24333

View Options

desktop/konsole.notifyrc

Loading...