Differential D9469

Fix build of knotifications on Mac
ClosedPublic
Actions

Authored by arichardson on Dec 21 2017, 5:07 PM.

Details

Reviewers
kfunk
Group Reviewers
Craft
Commits
R877:7cb20a4b0383: Fix build of knotifications on Mac
Summary

It seems like it depends on qtmacextras which doesn't have a package yet

Test Plan

Without this change it get the following error:

CMake Error at CMakeLists.txt:60 (find_package):
  Could not find a package configuration file provided by "Qt5MacExtras"
  (requested version 5.7.0) with any of the following names:

    Qt5MacExtrasConfig.cmake
    qt5macextras-config.cmake

  Add the installation prefix of "Qt5MacExtras" to CMAKE_PREFIX_PATH or set
  "Qt5MacExtras_DIR" to a directory containing one of the above files.  If
  "Qt5MacExtras" provides a separate development package or SDK, be sure it
  has been installed.

Diff Detail

Repository
R877 Craft Blueprints for KDE
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
arichardson requested review of this revision.Dec 21 2017, 5:07 PM
arichardson created this revision.
kfunk accepted this revision.Dec 22 2017, 5:18 PM
kfunk added a subscriber: kfunk.

Thanks!

This revision is now accepted and ready to land.Dec 22 2017, 5:18 PM
Closed by commit R877:7cb20a4b0383: Fix build of knotifications on Mac (authored by arichardson). · Explain WhyDec 23 2017, 4:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24257

View Options

frameworks/tier3/knotifications/knotifications.py

Loading...
View Options

libs/qt5/qtmacextras/qtmacextras.py

Loading...