Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation
ClosedPublic

Authored by habacker on Dec 21 2017, 4:57 PM.

Details

Summary

Access to the internal global static is provided by the already available
method Solid::Networking::notifier().

Because the Windows implementation uses QNetworkConfigurationManager for
detecting network connection state, the network status cannot be changed
by test application networkingservice. To see network status changes in
networkingclient test application it is required to disable the maschine
network adapter.

FIXED-IN:5.43.0

Test Plan
  • unix: compiled and verified with networkingservice/networkingclient test apps
  • Window: compiled and tested by disabling network adapter (see notes above)

Diff Detail

Repository
R239 KDELibs4Support
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
habacker created this revision.Dec 21 2017, 4:57 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 21 2017, 4:57 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
habacker requested review of this revision.Dec 21 2017, 4:57 PM
habacker updated this revision to Diff 25088.Jan 10 2018, 2:05 PM
  • fix generating slot access code
habacker edited the summary of this revision. (Show Details)Jan 10 2018, 2:07 PM
habacker edited the test plan for this revision. (Show Details)
dfaure accepted this revision.Jan 21 2018, 9:28 PM
This revision is now accepted and ready to land.Jan 21 2018, 9:28 PM
This revision was automatically updated to reflect the committed changes.