Also list GTK 3 themes without "gtk-3.0" subfolder
ClosedPublic
Actions

Authored by fvogt on Dec 21 2017, 2:50 PM.

Details

Reviewers

lbeltrame
apol

Group Reviewers

Plasma

Commits

Summary

It is valid to have themes without support for gtk3 < 3.14.

Test Plan

Ran kcmshell5 kde-gtk-config with breeze-gtk from git installed. Now it appears.

Repository

R99 KDE Gtk Configuration Tool

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

fvogt requested review of this revision.Dec 21 2017, 2:50 PM

Looks good, some nitpicking.

src/appearancegtk3.cpp
46	constBegin/constEnd
49	The name filters can be the first argument here

src/appearancegtk3.cpp
46	I did not touch that, should I still change it?
49	Indeed, adjusting.

Use const{Begin,End} and a entryList overload.

arc picked two commits at once...

This revision is now accepted and ready to land.Dec 21 2017, 3:55 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/appearancegtk3.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24234	9615fc3		Dec 21 2017, 2:50 PM	★	★
Diff 2	24247	83c6deb	Use const{Begin,End} and a entryList overload.	Dec 21 2017, 3:55 PM	★	★
Diff 3	24248	9615fc3	arc picked two commits at once...	Dec 21 2017, 3:55 PM	★	★
Diff 4	24255	9615fc3	R99:1ba9f200f0fb53b1dab7e810f8a1920f18e55322	Dec 21 2017, 3:54 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
1ba9f200f0fb	eebbbf559478	9615fc3994f9	Fabian Vogt	Also list GTK 3 themes without "gtk-3.0" subfolder (Show More…)	Dec 21 2017, 2:47 PM