Differential D9454

Remove impossible to reach code
ClosedPublic
Actions

Authored by vkrause on Dec 21 2017, 2:08 PM.

Details

Reviewers
dfaure
Commits
R303:f68d54697318: Remove impossible to reach code
Summary

This also brings this back in sync with src/kdeinit/kinit.cpp.

Diff Detail

Repository
R303 KInit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Dec 21 2017, 2:08 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 21 2017, 2:08 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
vkrause requested review of this revision.Dec 21 2017, 2:08 PM
dfaure accepted this revision.Dec 21 2017, 2:20 PM
dfaure added inline comments.
src/wrapper.cpp
49–50

Move this comment above the #if (of line 46), since that's what it's commenting about.

This revision is now accepted and ready to land.Dec 21 2017, 2:20 PM
vkrause updated this revision to Diff 24249.Dec 21 2017, 4:06 PM

address review comment

dfaure accepted this revision.Dec 21 2017, 4:10 PM
Closed by commit R303:f68d54697318: Remove impossible to reach code (authored by vkrause). · Explain WhyDec 21 2017, 4:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kdeinit/kinit.cpp (2 lines)
Msrc/wrapper.cpp (8 lines)

Diff 24250

View Options

src/kdeinit/kinit.cpp

Loading...
View Options

src/wrapper.cpp

Loading...