Match license keys by spdx
ClosedPublic
Actions

Authored by davidedmundson on Dec 20 2017, 5:11 PM.

Details

Reviewers

apol

Commits

R244:0d417760a53f: Match license keys by spdx

Summary

KAboutLicense supports exporting a license as an spdx ID.
(https://spdx.org/licenses/)

However the KAboutLicense::fromKeyword doesn't match

We have a lot of metadata where people are using the spdx id
rather than the somewhat arbitrary keyword format that KAboutLicense
expects.

This adds a unit test to make sure all supported license keys match up
then expands the keyword list.

Repository

R244 KCoreAddons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

davidedmundson requested review of this revision.Dec 20 2017, 5:11 PM

This revision is now accepted and ready to land.Dec 20 2017, 5:20 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/kaboutdatatest.cpp (13 lines)
M			src/lib/kaboutdata.h (2 lines)
M			src/lib/kaboutdata.cpp (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24176	a71d993		Dec 20 2017, 5:11 PM	★	★
Diff 2	24177	a71d993	R244:0d417760a53fbb605be414151ee81cf4b1fce3bf	Dec 20 2017, 5:11 PM	★	★