Differential D9405

[Uri Filter Search Provider] readName() of KDesktopFile
ClosedPublic
Actions

Authored by broulik on Dec 19 2017, 10:29 AM.

Details

Reviewers
dfaure
Commits
R241:8a32c8c4aeb9: [Uri Filter Search Provider] readName() of KDesktopFile
Summary

In 6246cc48 this code was ported away from KServiceTypeTrader where accidentally a service->name() which returns the translated name of the service to KDesktopFile::name() which returns the file path of the desktop file.

Test Plan

Typed "gg test" into krunner, now got

Search 'Google' for 'test'

instead of

Search '/usr/share/kservices5/searchproviders/google.desktop' for 'test'

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 19 2017, 10:29 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 19 2017, 10:29 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik requested review of this revision.Dec 19 2017, 10:29 AM
dfaure accepted this revision.Dec 19 2017, 6:11 PM

Oops :-)

This revision is now accepted and ready to land.Dec 19 2017, 6:11 PM
Closed by commit R241:8a32c8c4aeb9: [Uri Filter Search Provider] readName() of KDesktopFile (authored by broulik). · Explain WhyDec 20 2017, 10:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24149

View Options

src/urifilters/ikws/searchprovider.cpp

Loading...