Differential D939

Fix TestModels::testVcsFileChangesModel regression.
AbandonedPublic
Actions

Authored by mwolff on Feb 14 2016, 4:50 PM.

Details

Reviewers
None
Group Reviewers
KDevelop
Summary

When queried for the custom data roles, always delegate to the
custom VcsStatusInfoItem. This fixes an issue uncovered by the test,
where the QStandardItem holding the icon and path is returned
instead of the VcsStatusInfoItem. This item has no knowledge of the
custom data roles, and thus always returns invalid QVariants then.

Test Plan

Works now

Diff Detail

Repository
R33 KDevPlatform
Branch
5.0
Lint
No Linters Available
Unit
No Unit Test Coverage
mwolff updated this revision to Diff 2298.Feb 14 2016, 4:50 PM
mwolff retitled this revision from to Fix TestModels::testVcsFileChangesModel regression..
mwolff updated this object.
mwolff edited the test plan for this revision. (Show Details)
mwolff added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 14 2016, 4:50 PM
kfunk added a subscriber: apol.Feb 14 2016, 8:22 PM
mwolff abandoned this revision.Feb 15 2016, 9:21 PM

kevin pushed a fix now

kfunk added a subscriber: kfunk.Feb 15 2016, 9:25 PM

Sorry! I forgot there was a patch on Phab :)

commit 2a8c90b5ec8450dc67376ed1838054e8b261ac3e
Author: Kevin Funk <kfunk@kde.org>
Date: Mon Feb 15 22:19:47 2016 +0100

Fix TestModels test

Revision Contents
Changeset List

Diff 2298

View Options

vcs/models/tests/test_models.cpp

Loading...
View Options

vcs/models/vcsfilechangesmodel.cpp

Loading...