Differential D9383

Use correct service executable path for installing kwalletd dbus service on Win32
ClosedPublic
Actions

Authored by habacker on Dec 17 2017, 7:44 PM.

Details

Reviewers
dfaure
ltoscano
bcooksley
Commits
R311:74ce261240ae: Use correct service executable path for installing kwalletd dbus service on…
Summary

On Windows service executables are installed in the same directory as
normal executables and therefore need to be specified without any path
component, which is not provided with the original template.

Test Plan

cross compiled and tested by inspecting the resulting file

Diff Detail

Repository
R311 KWallet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
habacker created this revision.Dec 17 2017, 7:44 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 17 2017, 7:44 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
habacker requested review of this revision.Dec 17 2017, 7:44 PM
bcooksley requested changes to this revision.Dec 17 2017, 10:08 PM

Rather than writing the content of the file out from CMakeLists it should probably be a template as well, even if it's a second file.

This revision now requires changes to proceed.Dec 17 2017, 10:08 PM
habacker updated this revision to Diff 24054.Dec 18 2017, 9:33 AM
  • use service file template also for Windows
dfaure accepted this revision.Dec 19 2017, 10:29 PM
Closed by commit R311:74ce261240ae: Use correct service executable path for installing kwalletd dbus service on… (authored by habacker). · Explain WhyDec 20 2017, 1:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24134

View Options

src/runtime/kwalletd/CMakeLists.txt

Loading...
View Options

src/runtime/kwalletd/org.kde.kwalletd5.service.win.in

Loading...