XML (Debug): Fix incorrect DetectChar rule
ClosedPublic

Authored by dhaumann on Dec 17 2017, 11:52 AM.

Details

Summary

The fix is to simply remove the parts of the char that were
ignored anyways. Whether this is the correct patch is up for
discussion - but since noone complained for years, this is
possibly not a big issue anyways. And: the XML (Debug) file
does not have any extension nor mimetype, so we can safely
say essentially noone is using this...

Fixes:
checkSingleChars: xmldebug.xml" line 130 'char' must contain exactly one char: "\"(\\s+|$)"
checkSingleChars: xmldebug.xml" line 135 'char' must contain exactly one char: "'(\\s+|$)"
checkSingleChars: xmldebug.xml" line 374 'char' must contain exactly one char: "\"(\\s+|$)"
checkSingleChars: xmldebug.xml" line 379 'char' must contain exactly one char: "'(\\s+|$)"
checkSingleChars: xmldebug.xml" line 416 'char' must contain exactly one char: "\"(\\s+|$)"
checkSingleChars: xmldebug.xml" line 421 'char' must contain exactly one char: "'(\\s+|$)"
checkSingleChars: xmldebug.xml" line 468 'char' must contain exactly one char: "\"(\\s+|$)"
checkSingleChars: xmldebug.xml" line 473 'char' must contain exactly one char: "'(\\s+|$)"

Test Plan

make test

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Dec 17 2017, 11:52 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 17 2017, 11:52 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann requested review of this revision.Dec 17 2017, 11:52 AM
vkrause accepted this revision.Dec 17 2017, 11:54 AM
This revision is now accepted and ready to land.Dec 17 2017, 11:54 AM
This revision was automatically updated to reflect the committed changes.