Following up on D9272; this diff changes reassigning the old profile shortcut to the newly renamed profile if deleting the old profile returns true. This was if the profile is in read-only dir the shortcut isn't reassigned.
Details
Details
- Reviewers
hindenburg - Group Reviewers
Konsole - Commits
- R319:41200618e73f: Only reassign renamed profile's shortcut if old profile is deleted.
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
With the patch, I still see the shortcut on both profiles in the manage profile dialog.
Once you close the dialog, only the r/o profile has the shortcut.
Comment Actions
Both profiles have the same name? we still haven't fixed the issue where konsole writes/saves a profile read from /usr/share/konsole to ~/.local/share/konsole with the same name.
This diff is more of a safe-guard, if for whatever reason deleteProfile() fails, the shortcut should stay with the old/orig profile.
I'm still working on a patch for profiles under /usr/share/konsole.