Differential D9314

[Kickoff] Move DragHelper to FullRepresentation
ClosedPublic
Actions

Authored by broulik on Dec 13 2017, 4:12 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:98ab6b30394c: [Kickoff] Move DragHelper to FullRepresentation
Summary

It is only accessed from items within it (KickoffItem), there's no need to create it initially.

Test Plan

Re-arranging favorites still works and so does dragging apps to e.g. desktop

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Dec 13 2017, 4:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 13 2017, 4:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 13 2017, 4:12 PM
hein accepted this revision.Dec 13 2017, 5:17 PM
This revision is now accepted and ready to land.Dec 13 2017, 5:17 PM
Closed by commit R119:98ab6b30394c: [Kickoff] Move DragHelper to FullRepresentation (authored by broulik). · Explain WhyDec 13 2017, 5:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23871

View Options

applets/kickoff/package/contents/ui/FullRepresentation.qml

Loading...
View Options

applets/kickoff/package/contents/ui/Kickoff.qml

Loading...