Acquire wifi multicast lock
AbandonedPublic

Authored by mtijink on Dec 12 2017, 1:52 PM.

Details

Reviewers
None
Group Reviewers
KDE Connect
Summary

This ensures the device can receive UDP broadcast packets, required for discovering devices correctly.

May appear unnecessary for some devices/other installed applications, but is needed for correctness (see https://stackoverflow.com/questions/30648334/is-change-wifi-multicast-state-permission-and-use-of-wifimanager-multicastlock-r or https://stackoverflow.com/questions/27838660/moto-g-dosent-receive-udp-packets-over-wifi-network)

Test Plan

Worked on my device, but it does not appear necessary for my device either. Hopefully it solves some problems for others.

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
wifi-multicast-lock
Lint
No Linters Available
Unit
No Unit Test Coverage
mtijink requested review of this revision.Dec 12 2017, 1:52 PM
mtijink created this revision.

Disclaimer: Anything following might be wrong
As far as I understand there is a difference between broadcast and multicast (see http://www.utilizewindows.com/the-difference-between-unicast-multicast-and-broadcast-messages/). We are BROADcasting to discover devices (to 255.255.255.255 to be specific), so this might not change anything at all.
On the other hand, the second link indeed implies that this could solve some issues. It would be nice if we actually found somebody with a concrete issue.

mtijink abandoned this revision.Dec 21 2017, 12:31 PM

I think you're right, although the naming makes it all a bit confusing. I guess we can look at it again if someone reports a bug about this.