Port plasma-integration to explicit wayland AppMenu protocol
ClosedPublic

Authored by davidedmundson on Dec 8 2017, 12:20 PM.

Details

Summary

Also fixed to handle the case of surfaces not having the lifespan of the
window, which the old code didn't handle.

I don't think it's worth trying to handle the case of different versions
of kwin and plasma-integration.

Test Plan

Made relevant kwin change and it gets communicated fine

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.Dec 8 2017, 12:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 8 2017, 12:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 8 2017, 12:20 PM

Martin F: One idea suggested was to use the same interface for all generic window -> kwin specific things and move the server side palette into the same interface.

It'd mean a few renames, but be a lot less work overall, particularly when we want to add new things.

Do you have an opinion on that?

Fix a hypothetical case of the manager not existing and the QPT being used

I'm not really used to being addressed as Martin F. yet - I just realized.

I see pro and cons for both. Personally I think it is better to have destinct interfaces for different functionality. It's easier for the case that someone else wants to reuse this. And that has already happened. Given that I would say the overhead of dedicated protocols is worth the effort.

graesslin accepted this revision.Dec 8 2017, 3:59 PM
This revision is now accepted and ready to land.Dec 8 2017, 3:59 PM
This revision was automatically updated to reflect the committed changes.