Differential D9222

[Folder View] Show "Widgets unlocked" help only for containment
ClosedPublic
Actions

Authored by broulik on Dec 6 2017, 10:00 AM.

Details

Reviewers
hein
davidedmundson
Group Reviewers
Plasma
Commits
R119:7e2801974ab5: [Folder View] Show "Widgets unlocked" help only for containment
Summary

When removing a widget it turns system immutable, when undoing it regains its old immutability triggering the notification.
Rather than tracking whether immutability changed from system or user immutability, just don't spawn the notification if not a containment, which makes sense anyway.

BUG: 387589
FIXED-IN: 5.11.5

Test Plan
  • Added folder view widget, removed it, clicked "Undo", widget re-appeared without notification
  • Used folder view as containment, locked widgets, unlocked widgets, still got the notification like before

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 6 2017, 10:00 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 6 2017, 10:00 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 6 2017, 10:00 AM
davidedmundson accepted this revision.Dec 6 2017, 10:09 AM
This revision is now accepted and ready to land.Dec 6 2017, 10:09 AM
Closed by commit R119:7e2801974ab5: [Folder View] Show "Widgets unlocked" help only for containment (authored by broulik). · Explain WhyDec 7 2017, 12:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23612

View Options

containments/desktop/package/contents/ui/main.qml

Loading...