Differential D9221

[KLineEdit] Use Qt's built-in clear button functionality
ClosedPublic
Actions

Authored by broulik on Dec 6 2017, 9:42 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Frameworks
Commits
R284:92f59edf698a: [KLineEdit] Use Qt's built-in clear button functionality
Summary

It saves the need to create a QProxyStyle which creates a separate QStyle instance for itself and Breeze widget style is quite heavy to load.

Test Plan

Tests still pass
Played around in klineedittest and it worked fine
Also verified that the buttonUsedSize is roughly (same width, slightly taller) the same size as it used to be.
KLineEdit no longer shows up in profiler

Diff Detail

Repository
R284 KCompletion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 6 2017, 9:42 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 6 2017, 9:42 AM
broulik requested review of this revision.Dec 6 2017, 9:42 AM
broulik updated this revision to Diff 29479.Mar 14 2018, 10:05 AM
broulik retitled this revision from WIP: [KLineEdit] Use Qt's built-in clear button functionality to [KLineEdit] Use Qt's built-in clear button functionality.
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Apr 24 2018, 2:48 PM
This revision is now accepted and ready to land.Apr 24 2018, 2:48 PM
Closed by commit R284:92f59edf698a: [KLineEdit] Use Qt's built-in clear button functionality (authored by broulik). · Explain WhyApr 24 2018, 2:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/klineedit.h (13 lines)
Msrc/klineedit.cpp (218 lines)
Msrc/klineedit_p.h (186 lines)

Diff 32978

View Options

src/klineedit.h

Loading...
View Options

src/klineedit.cpp

Loading...
View Options

src/klineedit_p.h

Loading...