Simple cleanup of QStringList{...}
Details
Details
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
better than before, but some things could be improved some more
| src/document/katedocument.cpp | ||
|---|---|---|
| 4518 | even better would be to not name this list type at all, to use initializer_list and then use STL algorithms on it, but this is already better. The advantage of my suggested pattern is that there is no memory allocation at all anymore. Compare https://godbolt.org/g/3SvKNw against https://godbolt.org/g/w9ySts (it should be similar for QStrings) | |
| 4613 | dito | |
| 4733 | dito | |
| 4739 | dito | |
| src/script/katescriptmanager.cpp | ||
| 119 | use auto on the left | |
| src/view/kateview.cpp | ||
| 1385–1402 | don't name a type (use initializer list) and then use range-based for below | |
Comment Actions
@mwolff I have a separate patch where I use STL algos in katedocument. I would like to keep this as separate patch, though. So is this change fine now?
make test still passes.
Comment Actions
yep this is better than before after all
| src/view/kateview.cpp | ||
|---|---|---|
| 1385–1402 | this could still be an initializer list | |