Differential D9202

Highlighting Indexer: Check for infinite loops
ClosedPublic
Actions

Authored by dhaumann on Dec 5 2017, 1:31 PM.

Details

Reviewers
vkrause
Commits
R216:1c0667ac6af8: Highlighting Indexer: Check for infinite loops
Summary

The infinite loop check looks for a lookAhead="true" in combination
with context="#stay". This would possibly lead to an infinite loop,
and indicates a bug in a highlighting file.

Test Plan

make test

Diff Detail

Repository
R216 Syntax Highlighting
Branch
CheckLookAhead (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
dhaumann created this revision.Dec 5 2017, 1:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 5 2017, 1:31 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann requested review of this revision.Dec 5 2017, 1:31 PM
dhaumann updated this revision to Diff 23503.Dec 5 2017, 1:34 PM

Fixed typo

dhaumann updated this revision to Diff 23504.Dec 5 2017, 1:35 PM

missing return true statement

vkrause accepted this revision.Dec 5 2017, 1:37 PM
This revision is now accepted and ready to land.Dec 5 2017, 1:37 PM
Closed by commit R216:1c0667ac6af8: Highlighting Indexer: Check for infinite loops (authored by dhaumann). · Explain WhyDec 5 2017, 1:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23503

View Options

data/syntax/cpp.xml

Loading...
View Options

src/indexer/katehighlightingindexer.cpp

Loading...