Differential D9195

port logout screen to kpackage fileUrl
ClosedPublic
Actions

Authored by mart on Dec 5 2017, 11:40 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:a645d1012293: port logout screen to kpackage fileUrl
Summary

port the shutdown dialog to package::fileUrl, dropping the support for old custom themes

Test Plan

shutdown dialog work correctly both with normal and rcc kpackages

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Dec 5 2017, 11:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 5 2017, 11:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Dec 5 2017, 11:40 AM
mart edited the summary of this revision. (Show Details)Dec 5 2017, 11:41 AM
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Plasma.
mart updated this revision to Diff 23487.Dec 5 2017, 11:45 AM
  • drop unused themes folder
broulik added a subscriber: broulik.Dec 5 2017, 12:16 PM

Can we please not mingle three separate things into one commit

mart updated this revision to Diff 23602.Dec 7 2017, 8:58 AM
  • split out wallpaper config
mart added a comment.Dec 7 2017, 8:59 AM
In D9195#176145, @broulik wrote:

Can we please not mingle three separate things into one commit

now the wallpaper dialog related parts are removed, is only about the logout dialog

mart retitled this revision from fix wallpaper config and logout screen to port logout screen to kpackage fileUrl.Dec 7 2017, 9:01 AM
mart edited the summary of this revision. (Show Details)
mart edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Dec 7 2017, 9:08 AM
This revision is now accepted and ready to land.Dec 7 2017, 9:08 AM
Closed by commit R120:a645d1012293: port logout screen to kpackage fileUrl (authored by mart). · Explain WhyDec 9 2017, 9:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23677

View Options

ksmserver/CMakeLists.txt

Loading...
View Options

ksmserver/logout-greeter/main.cpp

Loading...
View Options

ksmserver/shutdowndlg.h

Loading...
View Options

ksmserver/shutdowndlg.cpp

Loading...
View Options

ksmserver/themes/contour/ContourButton.qml

Loading...
View Options

ksmserver/themes/contour/main.qml

Loading...
View Options

ksmserver/themes/contour/metadata.desktop

Loading...
View Options

ksmserver/themes/contour/screenshot.png

Loading...
View Options

ksmserver/themes/default/KSMButton.qml

Loading...
View Options

ksmserver/themes/default/metadata.desktop

Loading...
View Options

ksmserver/themes/default/screenshot.png

Loading...