Differential D9194

Don't load KDE platform module in xembedsniproxy
ClosedPublic
Actions

Authored by hein on Dec 5 2017, 11:31 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:23c30cfba92d: Don't load KDE platform module in xembedsniproxy
Summary

xembedsniproxy doesn't do anything that requires it to be
aware of KDE GUI settings (colors, style, standard keys, etc).

This makes it start a fair bit faster.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Dec 5 2017, 11:31 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 5 2017, 11:31 AM
hein requested review of this revision.Dec 5 2017, 11:31 AM
broulik added a subscriber: broulik.Dec 5 2017, 12:17 PM
broulik added inline comments.
xembed-sni-proxy/main.cpp
57–58

It was clearly meant to be :)

davidedmundson accepted this revision.Dec 5 2017, 12:37 PM

please remove the useless line.
Ideally without running git blame first.

This revision is now accepted and ready to land.Dec 5 2017, 12:37 PM
hein updated this revision to Diff 23493.Dec 5 2017, 12:39 PM

Remove David's line.

That one can't work because the app's already been instantiated then.

Closed by commit R120:23c30cfba92d: Don't load KDE platform module in xembedsniproxy (authored by hein). · Explain WhyDec 5 2017, 12:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mxembed-sni-proxy/main.cpp (4 lines)

Diff 23494

View Options

xembed-sni-proxy/main.cpp

Loading...