Differential D9185

overhaul RatingStar
ClosedPublic
Actions

Authored by astippich on Dec 4 2017, 8:24 PM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Maniphest Tasks
T7529: overhaul RatingStar
Commits
R255:6cb1e1dbd61e: overhaul RatingStar
Summary

removes the copy & paste code in RatingStar and uses a repeater instead.
Fixes T7529 and also the recently reported bug. Rating can now be deselected on every star.
Also cleans up the size definition for the star.

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Dec 4 2017, 8:24 PM
astippich created this revision.
astippich added a comment.Dec 4 2017, 8:26 PM

Handling the hover effect with the repeater was a little bit complicated, but I think I've found a nice solution. Feedback welcome of course.

mgallien accepted this revision.Dec 6 2017, 9:15 PM
mgallien added a subscriber: mgallien.

Less code is always better.
Thanks, it is working fine.

This revision is now accepted and ready to land.Dec 6 2017, 9:15 PM
Closed by commit R255:6cb1e1dbd61e: overhaul RatingStar (authored by astippich). · Explain WhyDec 8 2017, 5:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/RatingStar.qml (254 lines)
Msrc/Theme.qml (2 lines)

Diff 23665

View Options

src/RatingStar.qml

Loading...
View Options

src/Theme.qml

Loading...