return nullptr -> return {} for QFlags
ClosedPublic
Actions

Authored by mkoller on Dec 4 2017, 6:23 PM.

Details

Reviewers

kfunk
kossebau

Commits

R287:7f2c44add4aa: Use brace-initializer instead of nullptr in returning 0-QFlags

Summary

Change the irritating nullptr return value to {} for the QImageIOPlugin::Capabilities QFlags

Diff Detail

Repository

R287 KImageFormats

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mkoller created this revision.Dec 4 2017, 6:23 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptDec 4 2017, 6:23 PM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

mkoller requested review of this revision.Dec 4 2017, 6:23 PM

Code change looks good to me. Think I missed that in my clean-up commits to @kfunk 's initial commit as I only compiled the library parts of KDE Frameworks, not the plugin modules.

No maintainer of this module though, so just a +1 for now.

Commit message could perhaps be extended to quickly note why the nullptr has been there at all, so future commit history readers get a clue, which they do not from a "irritating" attribution :)

For the record, see comment https://phabricator.kde.org/D3987#174960

This revision is now accepted and ready to land.Dec 5 2017, 8:23 AM

Closed by commit R287:7f2c44add4aa: Use brace-initializer instead of nullptr in returning 0-QFlags (authored by mkoller). · Explain WhyDec 5 2017, 6:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/imageformats/eps.cpp (4 lines)
M			src/imageformats/exr.cpp (4 lines)
M			src/imageformats/kra.cpp (4 lines)
M			src/imageformats/ora.cpp (4 lines)
M			src/imageformats/pcx.cpp (4 lines)
M			src/imageformats/pic.cpp (4 lines)
M			src/imageformats/psd.cpp (4 lines)
M			src/imageformats/ras.cpp (4 lines)
M			src/imageformats/rgb.cpp (4 lines)
M			src/imageformats/tga.cpp (4 lines)
M			src/imageformats/xcf.cpp (4 lines)