Differential D9132

Highlighting Indexer: Warn about duplicate contexts
ClosedPublic
Actions

Authored by dhaumann on Dec 3 2017, 2:06 PM.

Details

Reviewers
vkrause
Commits
R216:621e282acbcb: Highlighting Indexer: Warn about duplicate contexts
Summary

Warn, if two contexts have the same name.

Currently, we have the following issues:
ContextChecker::processElement: "data/syntax/cgis.xml" context duplicate: "Region Marker"
ContextChecker::processElement: "data/syntax/cgis.xml" context duplicate: "Commentar 1"
ContextChecker::processElement: "data/syntax/cgis.xml" context duplicate: "Commentar 2"
ContextChecker::processElement: "data/syntax/diff.xml" context duplicate: "File"
ContextChecker::processElement: "data/syntax/objectivecpp.xml" context duplicate: "Preprocessor"
ContextChecker::processElement: "data/syntax/spice.xml" context duplicate: "String"

Test Plan

make && make test

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Dec 3 2017, 2:06 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 3 2017, 2:06 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann requested review of this revision.Dec 3 2017, 2:06 PM
vkrause accepted this revision.Dec 3 2017, 2:06 PM
This revision is now accepted and ready to land.Dec 3 2017, 2:06 PM
Closed by commit R216:621e282acbcb: Highlighting Indexer: Warn about duplicate contexts (authored by dhaumann). · Explain WhyDec 3 2017, 2:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23342

View Options

src/indexer/katehighlightingindexer.cpp

Loading...