Differential D9129

Highlighting Indexer: Check for duplicate itemDatas
ClosedPublic
Actions

Authored by dhaumann on Dec 3 2017, 1:47 PM.

Details

Reviewers
vkrause
Commits
R216:6b7cd0c8735a: Highlighting Indexer: Check for duplicate itemDatas
Summary

Check for duplicate itemData entries during indexing.

Currently, there are the following duplicates:
AttributeChecker::processElement: "data/syntax/haml.xml" itemData duplicate: "Symbol"
AttributeChecker::processElement: "data/syntax/haml.xml" itemData duplicate: "String"
AttributeChecker::processElement: "data/syntax/haml.xml" itemData duplicate: "Keyword"
AttributeChecker::processElement: "data/syntax/ilerpg.xml" itemData duplicate: "Float"
AttributeChecker::processElement: "data/syntax/ilerpg.xml" itemData duplicate: "Float"
AttributeChecker::processElement: "data/syntax/rhtml.xml" itemData duplicate: "Error"
AttributeChecker::processElement: "data/syntax/systemverilog.xml" itemData duplicate: "Data Type Keyword"
AttributeChecker::processElement: "data/syntax/systemverilog.xml" itemData duplicate: "Preprocessor Keyword"
AttributeChecker::processElement: "data/syntax/systemverilog.xml" itemData duplicate: "System Task Keyword"
AttributeChecker::processElement: "data/syntax/systemverilog.xml" itemData duplicate: "Drive/Charge Strength Keyword"
AttributeChecker::processElement: "data/syntax/systemverilog.xml" itemData duplicate: "Gate Instantiation Keyword"
AttributeChecker::processElement: "data/syntax/xul.xml" itemData duplicate: "Comment"

Test Plan

make && make test

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Dec 3 2017, 1:47 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 3 2017, 1:47 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann requested review of this revision.Dec 3 2017, 1:47 PM
vkrause accepted this revision.Dec 3 2017, 1:48 PM
This revision is now accepted and ready to land.Dec 3 2017, 1:48 PM
Closed by commit R216:6b7cd0c8735a: Highlighting Indexer: Check for duplicate itemDatas (authored by dhaumann). · Explain WhyDec 3 2017, 1:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23338

View Options

src/indexer/katehighlightingindexer.cpp

Loading...