Differential D9110

Cache value before loop
ClosedPublic
Actions

Authored by mlaurent on Dec 2 2017, 4:53 PM.

Details

Reviewers
dfaure
sandsmark
Commits
R246:8de9d6953c0f: Cache value before loop

Diff Detail

Repository
R246 Sonnet
Branch
avoid_check_all_the_time
Lint
No Linters Available
Unit
No Unit Test Coverage
mlaurent created this revision.Dec 2 2017, 4:53 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 2 2017, 4:53 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
mlaurent requested review of this revision.Dec 2 2017, 4:53 PM
dfaure requested changes to this revision.Dec 2 2017, 5:30 PM

Good idea.

src/core/backgroundchecker.cpp
59 ↗(On Diff #23291)

make those bools const, for readability.

This revision now requires changes to proceed.Dec 2 2017, 5:30 PM
mlaurent updated this revision to Diff 23305.Dec 2 2017, 6:34 PM
  • Make boolean as const for readibility
dfaure accepted this revision.Dec 2 2017, 7:21 PM
This revision is now accepted and ready to land.Dec 2 2017, 7:21 PM
Closed by commit R246:8de9d6953c0f: Cache value before loop (authored by mlaurent). · Explain WhyDec 2 2017, 7:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23305

View Options

src/core/backgroundchecker.cpp

Loading...
View Options

src/ui/highlighter.cpp

Loading...