Performance
ClosedPublic
Actions

Authored by apol on Dec 2 2017, 2:56 PM.

Details

Reviewers

Group Reviewers

Frameworks
Plasma

Commits

R242:1f9b5ed657df: Performance

Summary

Remove splitting + joining of a string just to remove the beginning of a
string.
Remove double look-up.
Solves Clazy warnings

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

apol requested review of this revision.Dec 2 2017, 2:56 PM

hein added inline comments.

src/plasmaquick/packageurlinterceptor.cpp
166	Should be 'firstSlash < (relativePath.size() - 1)'?

Remove crazy check

hein accepted this revision.Dec 2 2017, 3:11 PM

This revision is now accepted and ready to land.Dec 2 2017, 3:11 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/declarativeimports/calendar/eventpluginsmanager.cpp (1 line)
M			src/declarativeimports/core/datamodel.cpp (4 lines)
M			src/declarativeimports/core/framesvgitem.cpp (4 lines)
M			src/declarativeimports/core/iconitem.h (2 lines)
M			src/declarativeimports/core/iconitem.cpp (4 lines)
M			src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp (2 lines)
M			src/declarativeimports/plasmacomponents/qmenu.cpp (2 lines)
M			src/plasma/containment.cpp (2 lines)
M			src/plasma/corona.h (10 lines)
M			src/plasma/dataengine.cpp (2 lines)
M			src/plasma/private/applet_p.cpp (2 lines)
M			src/plasma/private/associatedapplicationmanager.cpp (1 line)
M			src/plasma/private/storage.cpp (8 lines)
M			src/plasma/private/storagethread.cpp (4 lines)
M			src/plasma/private/theme_p.cpp (4 lines)
M			src/plasmaquick/packageurlinterceptor.cpp (19 lines)
M			src/scriptengines/qml/plasmoid/declarativeappletscript.h (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23282	b8b8a69		Dec 2 2017, 2:56 PM	★	★
Diff 2	23283	b8b8a69	Remove crazy check	Dec 2 2017, 3:10 PM	★	★
Diff 3	23285	b8b8a69	R242:1f9b5ed657dfc690a565314bd57aaf84eacc534f	Dec 2 2017, 3:22 PM	★	★