Differential D9077

Bug 377342 Question
AbandonedPublic
Actions

Authored by cullmann on Nov 30 2017, 8:24 PM.

Details

Reviewers
christofg
Summary

I have a little question related to migrating from QRegExp to QRegularExpression in ktexteditor. I first changed only on occurrence for now, pls see the attached diff. I hope this works as a quick solution to the problem but I'm not sure here.

I would like to change every occurrence in ktexteditor. Todo that I need to change KateRegExp. By doing that I would touch a lot more of the code.

My question now is, what's the best way to get started here ... Change one occurrence at a time, or do them all at once ...

I appreciate the help :)

Related Bug

Diff Detail

Repository
R39 KTextEditor
Lint
Lint Skipped
Unit
Unit Tests Skipped
christofg created this revision.Nov 30 2017, 8:24 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptNov 30 2017, 8:24 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
christofg requested review of this revision.Nov 30 2017, 8:24 PM
loh.tar added subscribers: cullmann, loh.tar.EditedDec 8 2018, 8:10 AM

@cullmann I think you could give a short hint

But perhaps is @christofg no longer interested to work on this issue

Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. · View Herald TranscriptDec 8 2018, 8:10 AM
cullmann commandeered this revision.Dec 8 2018, 5:21 PM
cullmann added a reviewer: christofg.

:( Sorry that this never got attention.

We have already

https://phabricator.kde.org/D9175

for this, that includes this change and more, but was never finalized.
If somebody can pick that other thing up, might be most useful, I will close this one.

Revision Contents
Changeset List

Diff 23188

View Options

src/search/kateplaintextsearch.h

Loading...
View Options

src/search/kateplaintextsearch.cpp

Loading...