Differential D9054

[CopyJob] Don't start all over after having removed a file
ClosedPublic
Actions

Authored by broulik on Nov 29 2017, 3:50 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:0bc40d7c8b71: [CopyJob] Don't start all over after having removed a file
Test Plan

(I didn't git graft the original commit which might explain this?) But shouldSkip() doesn't change any state so I don't see how starting all over could be needed.

Tests still pass

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Nov 29 2017, 3:50 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 29 2017, 3:50 PM
broulik requested review of this revision.Nov 29 2017, 3:50 PM
broulik edited the test plan for this revision. (Show Details)
dfaure accepted this revision.Nov 30 2017, 6:32 AM

Heh this goes back to 2000 and the make_it_cool branch for kio, with non-STL iterator api, I think the return value was just missing from Qt back then ;)

This revision is now accepted and ready to land.Nov 30 2017, 6:32 AM
Closed by commit R241:0bc40d7c8b71: [CopyJob] Don't start all over after having removed a file (authored by broulik). · Explain WhyNov 30 2017, 10:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/copyjob.cpp (6 lines)

Diff 23166

View Options

src/core/copyjob.cpp

Loading...