Use a distinct and more appropriate icon for Layers
ClosedPublic

Authored by ngraham on Nov 29 2017, 1:52 AM.

Details

Summary

BUG: 387424

Test Plan

Tested in KDE Neon. Before, using Breeze icons:

After, using Breeze icons:

Before, using Oxygen icons:

After, using Oxygen icons:

Diff Detail

Repository
R223 Okular
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Nov 29 2017, 1:52 AM
Restricted Application added a project: Okular. · View Herald TranscriptNov 29 2017, 1:52 AM
ngraham requested review of this revision.Nov 29 2017, 1:52 AM
ngraham edited the test plan for this revision. (Show Details)Nov 29 2017, 1:53 AM
aacid added a comment.Dec 2 2017, 12:33 AM

dialog-layers seems to be breeze only, which is not very good for people not using breeze :/

Darn. Can you think of a more universal icon that has an Oxygen equivalent?

aacid added a comment.Dec 2 2017, 10:17 AM

I didn't find anything back when we added this feature, worst case scenario one could copy the breeze icon into a okular- name and install it with okular but i guess it'd still look somewhat alien in other themes :/

Sadly I don't really have a better solution than the solution we did

rkflx added a subscriber: rkflx.Dec 2 2017, 10:36 AM

How about format-list-ordered or format-list-unordered? Those retain at least some of the layering semantics.

ngraham edited the test plan for this revision. (Show Details)Dec 2 2017, 3:05 PM

Excellent idea, @rkflx. format-list-unordered is much better than what I had chosen anyway.

ngraham updated this revision to Diff 23284.Dec 2 2017, 3:21 PM

Instead, use the format-list-unordered icon, which has an Oxygen version and is much better anyway

aacid accepted this revision.Dec 3 2017, 11:14 AM

I guess it's not worse than what we had :D

This revision is now accepted and ready to land.Dec 3 2017, 11:14 AM
ngraham closed this revision.Dec 3 2017, 4:21 PM
This revision was automatically updated to reflect the committed changes.