Fix check for inline methods in public classes
Fix check for methods that return 'const' refs in public classes
Details
Details
- Reviewers
tbaumgart - Group Reviewers
KMyMoney - Commits
- R261:91666bab0885: Refactor MyMoneyFile
All tests pass. Changed name of an account.
Diff Detail
Diff Detail
- Repository
- R261 KMyMoney
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Other than the stuff I have commented, it compiles fine and completes tests.
kmymoney/mymoney/mymoneyfile.h | ||
---|---|---|
721 | You need to change const MyMoneyAccount& MyMoneyQifReader::findAccount(const MyMoneyAccount& acc, const MyMoneyAccount& parent) const into MyMoneyAccount MyMoneyQifReader::findAccount(const MyMoneyAccount& acc, const MyMoneyAccount& parent) const and change const MyMoneyAccount& existingAccount = file->subAccountByName(parentAccount, name); to const MyMoneyAccount existingAccount = file->subAccountByName(parentAccount, name); in that method (around line 894). Also, there is another signature that needs to be updated. The method const MyMoneyAccount& KBankingPlugin::account(const QString& key, const QString& value) const should be converted to MyMoneyAccount KBankingPlugin::account(const QString& key, const QString& value) const |