Create d-pointer for MyMoneyForecast
ClosedPublic

Authored by wojnilowicz on Nov 22 2017, 4:31 PM.

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wojnilowicz created this revision.Nov 22 2017, 4:31 PM
tbaumgart requested changes to this revision.Nov 22 2017, 6:23 PM
tbaumgart added a subscriber: tbaumgart.

Ooops, fails here with:

[ 66%] Building CXX object kmymoney/mymoney/tests/CMakeFiles/mymoneyforecast-test.dir/mymoneyforecast-test.cpp.o                                                
In file included from /home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.cpp:17:
/home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.h:65:16: error: 
      field has incomplete type 'MyMoneyMoney'
  MyMoneyMoney moT1;
               ^
/home/thb/devel/kmymoney/kmymoney/mymoney/mymoneyfile.h:139:7: note: forward
      declaration of 'MyMoneyMoney'
class MyMoneyMoney;
      ^
In file included from /home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.cpp:17:
/home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.h:66:16: error: 
      field has incomplete type 'MyMoneyMoney'
  MyMoneyMoney moT2;
               ^
/home/thb/devel/kmymoney/kmymoney/mymoney/mymoneyfile.h:139:7: note: forward
      declaration of 'MyMoneyMoney'
class MyMoneyMoney;
      ^
In file included from /home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.cpp:17:
/home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.h:67:16: error: 
      field has incomplete type 'MyMoneyMoney'
  MyMoneyMoney moT3;
               ^
/home/thb/devel/kmymoney/kmymoney/mymoney/mymoneyfile.h:139:7: note: forward
      declaration of 'MyMoneyMoney'
class MyMoneyMoney;
      ^
In file included from /home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.cpp:17:
/home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.h:68:16: error: 
      field has incomplete type 'MyMoneyMoney'
  MyMoneyMoney moT4;
               ^
/home/thb/devel/kmymoney/kmymoney/mymoney/mymoneyfile.h:139:7: note: forward
      declaration of 'MyMoneyMoney'
class MyMoneyMoney;
      ^
In file included from /home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.cpp:17:
/home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.h:69:16: error: 
      field has incomplete type 'MyMoneyMoney'
  MyMoneyMoney moT5;
               ^
/home/thb/devel/kmymoney/kmymoney/mymoney/mymoneyfile.h:139:7: note: forward
      declaration of 'MyMoneyMoney'
class MyMoneyMoney;
      ^
In file included from /home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.cpp:17:
/home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.h:29:7: warning: 
      'MyMoneyForecastTest' has virtual functions but non-virtual destructor
      [-Wnon-virtual-dtor]
class MyMoneyForecastTest : public QObject
      ^
/home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.cpp:40:1: error: 
      no matching function for call to 'qExec'
QTEST_GUILESS_MAIN(MyMoneyForecastTest)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/qt5/QtTest/qtest.h:389:12: note: expanded from macro
      'QTEST_GUILESS_MAIN'
    return QTest::qExec(&tc, argc, argv); \
           ^~~~~~~~~~~~
/usr/include/qt5/QtTest/qtestcase.h:264:26: note: candidate function not viable:
      no known conversion from 'MyMoneyForecastTest *' to 'QObject *' for 1st
      argument
    Q_TESTLIB_EXPORT int qExec(QObject *testObject, int argc = 0, char *...
                         ^
/usr/include/qt5/QtTest/qtestcase.h:265:26: note: candidate function not viable:
      requires 2 arguments, but 3 were provided
    Q_TESTLIB_EXPORT int qExec(QObject *testObject, const QStringList &a...
                         ^
/home/thb/devel/kmymoney/kmymoney/mymoney/tests/mymoneyforecast-test.cpp:263:9: error: 
      no member named 'forecastAccountList' in 'MyMoneyForecast'
  b = a.forecastAccountList();
      ~ ^
This revision now requires changes to proceed.Nov 22 2017, 6:23 PM

Try to fix test compilation.

tbaumgart accepted this revision as: tbaumgart.Nov 23 2017, 6:22 AM

That compiles and tests run successful.

This revision was automatically updated to reflect the committed changes.