do not misuse QGroupBox as a layout helper, instead use a layout directly
ClosedPublic

Authored by sitter on Nov 22 2017, 1:08 PM.

Details

Summary

QGB with some styles has very unfortunate rendering if it has no title
nor frame configured. e.g. with the windows 9x style it renders the top
border line assuming there is a title even when there is none.
Ultimately we do not need QGB here at all though as we have it entirely
hidden and only use it as glorified layout container. So, replace QGB with
a Layout directly. Reduces excess code, memory footprint and fixes
appearance with various styles.

(technically we could put the entire setup into the designer file and
do away with the QButtonGroup as radios are autoexclusive with other
radios in the same parenting qwidget anyway; seems unncessarily invasive
though)

Test Plan

no more silly line artifact with windows 9x style; breeze continues to look stelar

Diff Detail

Repository
R352 Filelight
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Nov 22 2017, 1:08 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptNov 22 2017, 1:08 PM
adridg accepted this revision.Dec 5 2017, 5:32 PM
adridg added a subscriber: adridg.

LGTM. Better in Breeze (there's a little less padding before the radio buttons), Fusion and Win95 themes.

This revision is now accepted and ready to land.Dec 5 2017, 5:32 PM
This revision was automatically updated to reflect the committed changes.