Details
Diff Detail
- Repository
- R43 KDE PIM
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| kmail/editor/kmcomposewin.cpp | ||
|---|---|---|
| 1578 ↗ | (On Diff #2276) | it breaks the logic of slotIdentityChanged if we update mId directly. |
| 1592 ↗ | (On Diff #2276) | no sticky identities anymore -> so update the comments |
| 1599 ↗ | (On Diff #2276) | this todo doesn't makes sense anymore, or at least I do not understand what block should be moved |
| kmail/editor/kmcomposewin.cpp | ||
|---|---|---|
| 1508–1509 | don't use auto for uint please (for each simple type). | |
| kmail/editor/kmcomposewin.cpp | ||
|---|---|---|
| 1538 ↗ | (On Diff #2276) | Do you have a test case for it ? |
| kmail/editor/kmcomposewin.cpp | ||
|---|---|---|
| 1538 ↗ | (On Diff #2276) | Nope. The testcase in D892 is actuatually using the X-KMail-Identity header to give the information what identity should be used to kmcomposewin. But kmcomposerwin is initalized with the default identity. And with that a slotIdentityChanged is executed (see line 1555/1545 old/new). That's why I looked inside slotIdentityChanged and see that this function compare what different settings the old and new identitiy have. And only triggers something if there is a difference. So if we set mId before the diff is not available. -> so there is a test case that scrates the sureface of slotIdentityChanged. |
| kmail/editor/kmcomposewin.cpp | ||
|---|---|---|
| 1538 ↗ | (On Diff #2276) | So you need to move it in 891 |