Differential D892

Fixes 357481: honor the "always sign with GPG" flag in idendity
ClosedPublic
Actions

Authored by knauss on Feb 1 2016, 1:24 PM.

Details

Reviewers
mlaurent
Commits
R206:c9a5d0cdd0fd: Fixes 357481: honor the "always sign with GPG" flag in idendity
R43:385638c6b459: Fixes 357481: honor the "always sign with GPG" flag in idendity
Summary

added testcase
BUG: 357481

Diff Detail

Repository
R43 KDE PIM
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss updated this revision to Diff 2160.Feb 1 2016, 1:24 PM
knauss retitled this revision from to Fixes 357481: honor the "always sign with GPG" flag in idendity.
knauss updated this object.
knauss edited the test plan for this revision. (Show Details)
knauss added a reviewer: mlaurent.
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 1 2016, 1:24 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
knauss added a comment.Feb 1 2016, 1:30 PM

Currently I have still the issue, that the test doesn't stop by its own ( need to break it Ctrl+C). It looks for me that the akonadiServer does not shutdown.
But if i use akonadi_isolated test the test is not run at all.

knauss added a comment.Feb 1 2016, 2:20 PM
In D892#17238, @knauss wrote:

Currently I have still the issue, that the test doesn't stop by its own ( need to break it Ctrl+C). It looks for me that the akonadiServer does not shutdown.
But if i use akonadi_isolated test the test is not run at all.

fixed with switching to add_akonadi_isolated_test_advanced

knauss updated this revision to Diff 2161.Feb 1 2016, 2:23 PM

use add_akonadi_isolated_test_advanced for a akonadi test environment.

mlaurent added inline comments.Feb 4 2016, 5:42 AM
kmail/autotests/kmcommandstest.cpp
78

Remove all auto keyword please.
It's not complex element so we can write them.
and it's more easy to read code.

234

If commented we can remove them

knauss updated this revision to Diff 2188.Feb 4 2016, 1:34 PM
knauss marked 2 inline comments as done.

replace auto with the current type

kmail/autotests/kmcommandstest.cpp
234

Well we need this part, to have a clean emailidentity file and not touch the uses one. It was just a test what happens if I disable this.

mlaurent added inline comments.Feb 9 2016, 12:00 PM
kmail/autotests/kmcommandstest.cpp
236

QStandardPath::setTestModeEnabled(true) is not enough ?

knauss updated this revision to Diff 2250.Feb 9 2016, 1:54 PM
knauss marked an inline comment as done.

Remove not needed testdir for kdehome.

kmail/autotests/kmcommandstest.cpp
236

No because the test dir (~/.qttest) is not cleaned afterwards. And we rely on a clean emailidenties file, otherwise things mess up.

mlaurent accepted this revision.Feb 10 2016, 5:48 AM
mlaurent edited edge metadata.
This revision is now accepted and ready to land.Feb 10 2016, 5:48 AM
Closed by commit R43:385638c6b459: Fixes 357481: honor the "always sign with GPG" flag in idendity (authored by knauss). · Explain WhyFeb 10 2016, 1:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2278

View Options

kmail/autotests/CMakeLists.txt

Loading...
View Options

kmail/autotests/kmcommandstest.h

Loading...
View Options

kmail/autotests/kmcommandstest.cpp

Loading...
View Options

kmail/editor/composer.h

Loading...
View Options

kmail/editor/kmcomposewin.cpp

Loading...
View Options

kmail/kmmainwin.h

Loading...
View Options

kmail/kmreadermainwin.h

Loading...
View Options

kmail/kmreaderwin.h

Loading...