Differential D925

Don't change mId from outside
ClosedPublic
Actions

Authored by knauss on Feb 9 2016, 1:53 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM: KMail
Commits
R43:a3078eb55a97: Don't change mId from outside
R206:00d5619efecd: Don't change mId from outside
Summary

Changeing the mId should only be done inside slotIdentityChanged.

(part of formal D891)

Diff Detail

Repository
R43 KDE PIM
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss updated this revision to Diff 2249.Feb 9 2016, 1:53 PM
knauss retitled this revision from to Don't change mId from outside.
knauss updated this object.
knauss edited the test plan for this revision. (Show Details)
knauss added a reviewer: mlaurent.
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 9 2016, 1:53 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
mlaurent accepted this revision.Feb 10 2016, 5:45 AM
mlaurent edited edge metadata.
This revision is now accepted and ready to land.Feb 10 2016, 5:45 AM
Closed by commit R43:a3078eb55a97: Don't change mId from outside (authored by knauss). · Explain WhyFeb 10 2016, 1:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkmail/editor/kmcomposewin.cpp (3 lines)

Diff 2277

View Options

kmail/editor/kmcomposewin.cpp

Loading...