The takeDevice method calls dup, but that syscall removes the O_CLOEXEC flag
as a side-effect. This resulted in all child processes of kwin_wayland having
an open file descriptor for those devices.
Details
Details
- Reviewers
graesslin - Group Reviewers
Plasma - Commits
- R108:96af5965eeef: Fix leaking of FDs requested from logind
Looked at the open FDs of the startplasma script. Before, all
/dev/input/eventX files and /dev/dri/card0 were open. Now, none of those
are part of /proc/PID/fd/
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| logind.cpp | ||
|---|---|---|
| 387 | Which systems wouldn't have it? | |
| logind.cpp | ||
|---|---|---|
| 387 | FD_DUPFD_CLOEXEC is Linux specific. I don't know whether this code path could get used on BSDs. | |
Comment Actions
5.11 yes! Wayland support is not covered by LTS, so I don't see a need to fix in 5.8.
| logind.cpp | ||
|---|---|---|
| 387 | AFAIK libinput is Linux specific, so this code path can be Linux specific as well. | |