Differential D8877

make text vertically aligned to center for NavigationActionBar
ClosedPublic
Actions

Authored by astippich on Nov 18 2017, 9:56 AM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R255:2db951e394fa: make text vertically aligned to center for NavigationActionBar
Summary

The text in NavigationActionBar is set with a fixed margin to the top. Use the already available ColumnLayout to align it vertically centered.
This way it is also vertically aligned with the Enqeue and Play Now buttons. Affects MediaArtistAlbumView and MediaAlbumView

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Nov 18 2017, 9:56 AM
astippich added a comment.Nov 18 2017, 9:57 AM

Before:

After:

mgallien accepted this revision.Nov 18 2017, 3:34 PM
mgallien added a subscriber: mgallien.

Thanks for this. What do you think about improving a little bit the margin between Album title and album artist ?

This revision is now accepted and ready to land.Nov 18 2017, 3:34 PM
astippich added a comment.Nov 18 2017, 5:06 PM

I like it the way it is. It is the same as for the album delegates, e.g. compare the margin for the delegates in picture 3 and for picture 4. But I can add some more margin if you prefer.

mgallien added a comment.Nov 18 2017, 9:46 PM

Thanks for your work.
OK, please push it. I am a bit distracted by the size difference from the title font and the album artist font.

Closed by commit R255:2db951e394fa: make text vertically aligned to center for NavigationActionBar (authored by astippich). · Explain WhyNov 21 2017, 9:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/NavigationActionBar.qml (22 lines)

Diff 22709

View Options

src/NavigationActionBar.qml

Loading...