when reselecting e.g. the all albums view with the view selector, the stackview shows a previously openend album. Reset to the initial item when the view selector is used
Details
Details
- Reviewers
mgallien - Group Reviewers
Elisa - Commits
- R255:2fdcc82ac663: reset stackview to initial item when selected via ViewSelector
go to all albums and open an album. then select the all artist view and then select the album view again
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Personally I expect this behavior (same button always has same effect). If you disagree, feel free to just close this revision.
Comment Actions
- accept backspace key for backwards navigation
- remove unnecessary names for StateChangeScript
- Merge branch 'mouse_clicks' into content_view_navigation
- force active focus upon opening so that key navigation works
- add backward navigation with mouse
- revert selecting initial item, for separate bracnh
- Merge branch 'master' into content_view_navigation
- Merge branch 'master' into content_view_navigation
Comment Actions
something went wrong here, arcanist somehow thought that it should update this revision, but it should have created a new one
Comment Actions
Thanks for that.
I give some thoughts to your proposed change.
I think that it would work for you and for me if you would add a timer to only do the move after some time (in the order of seconds).
Sometime, I am switching between two view mode quite fast. In this case, I would prefer to keep the current state. At the same time, I agree with your rationale.
What do you think ?
Comment Actions
To be honest, I think that would be worse. The user will not know which view will be opened without any visual feedback. This would look random and maybe even like a bug to someone not knowing the internals. The existing behavior is better than a time-dependent button, I think.
Comment Actions
OK, let's go for that.
I will miss the ability to explore both an album and the associated artist. I will add a task to phabricator for that but with a dedicated UI (or buttons).
Comment Actions
I don't want to break your workflow. Maybe we should wait and commit once an alternative is in place?
Comment Actions
No, please go.
Do not worry.
In the full play list view, there is an artist name with an icon. I had the idea to allow to use that to navigate to the artist view. The idea is maybe worth using everywhere.