-playing indicator and remove button now share the position. indicator becomes invisible when entry is hovered or selected
-play button is transformed into a play pause button, allowing pause in the playlist entry. this is also a nice way to indicate the playing status when hovered or selected
Details
Details
- Reviewers
mgallien - Group Reviewers
Elisa - Commits
- R255:3fe029c5481f: change icons in playlist entry
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
After
Before
After
Feedback would be welcome on the animation duration, I set it to the same value as the entry color is changed. Just while writing this I thought that it is probably best to set it to the same duration as the icons appear, i.e. 50 ms, and not 200ms.
Comment Actions
Thanks for this change.
I tested it and it is nice.
I noticed that when in pause, the button stay visible behind the clear button. When playing, you only see the button on top of the play indicator. Could you try to improve that ?
Comment Actions
Sorry for the bug, somehow an inverted condition slipped through. I thought I tested it thoroughly, but obviously not enough.
Also shortened the animation duration.
Comment Actions
Thanks for your work.
Please land it via arcanist. I do remember when I did push my first contributions myself some years ago.
As a later step, would you mind adding animations on the opacity of the buttons ?
Comment Actions
I will commit once (and if) I get commit access (applied yesterday). The opacity is animated (already was before) , but with a very short duration (50ms) which is barely noticable but is consistent with MediaTracksDelegate, for example.