Simplify FavoriteCollectionsModel: inherit KSelectionProxyModel
ClosedPublic

Authored by dfaure on Nov 13 2017, 9:18 PM.

Details

Summary

instead of inheriting from Akonadi::SelectionProxyModel and disabling
the very little that Akonadi::SelectionProxyModel does compared to
its base class, KSelectionProxyModel.

And add a comment about why QSortFilterProxyModel wouldn't do,
replacing the comment that we should inherit from that instead.

Test Plan

Favorites work like before. The code is cleaner :)

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Nov 13 2017, 9:18 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 13 2017, 9:18 PM
dvratil accepted this revision.Nov 14 2017, 8:58 AM
This revision is now accepted and ready to land.Nov 14 2017, 8:58 AM
This revision was automatically updated to reflect the committed changes.