Simplify FavoriteCollectionsModel: inherit KSelectionProxyModel

Authored by dfaure on Nov 12 2017, 8:42 PM.

Description

Simplify FavoriteCollectionsModel: inherit KSelectionProxyModel

Summary:
instead of inheriting from Akonadi::SelectionProxyModel and disabling
the very little that Akonadi::SelectionProxyModel does compared to
its base class, KSelectionProxyModel.

And add a comment about why QSortFilterProxyModel wouldn't do,
replacing the comment that we should inherit from that instead.

Test Plan: Favorites work like before. The code is cleaner :)

Reviewers: dvratil, cmollekopf

Reviewed By: dvratil

Subscribers: KDE PIM

Tags: KDE PIM

Differential Revision: https://phabricator.kde.org/D8802

Details

Committed
dfaureNov 14 2017, 10:37 AM
Reviewer
dvratil
Differential Revision
D8802: Simplify FavoriteCollectionsModel: inherit KSelectionProxyModel
Parents
R165:c5a31c8d3257: Enable recursive filtering in EntityOrderProxyModel
Branches
Unknown
Tags
Unknown