Differential D877

Unify the test data of AkonadiStorageTest and AkonadiFakeStorageTest
ClosedPublic
Actions

Authored by ervin on Jan 27 2016, 10:37 PM.

Details

Reviewers
mlaurent
bensi
dfaure
dvratil
franckarrecot
Commits
R4:5a7e65cf3d1d: Unify the test data of AkonadiStorageTest and AkonadiFakeStorageTest
Summary

We had a slight difference in the test data due to a bug in tag based
item fetches that we chose to ignore. This bug has been fixed, so no
need to have different test data anymore (which in fact now cause a test
failure in shouldListItemsAssociatedWithTag).

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 2128.Jan 27 2016, 10:37 PM
ervin retitled this revision from to Unify the test data of AkonadiStorageTest and AkonadiFakeStorageTest.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: bensi, franckarrecot, dfaure, mlaurent, dvratil.
ervin updated this revision to Diff 2130.Jan 27 2016, 10:55 PM

Missed that another test was using the same data set

bensi accepted this revision.Jan 28 2016, 8:19 AM
bensi edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2016, 8:19 AM
Closed by commit R4:5a7e65cf3d1d: Unify the test data of AkonadiStorageTest and AkonadiFakeStorageTest (authored by ervin). · Explain WhyFeb 9 2016, 8:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2240

View Options

tests/units/akonadi/testenv/data/testdata.xml

Loading...
View Options

tests/units/testlib/akonadifakedataxmlloadertest.cpp

Loading...
View Options

tests/units/testlib/akonadifakedataxmlloadertest.xml

Loading...
View Options

tests/units/testlib/akonadifakestoragetest.cpp

Loading...