Fix fps limit config incorrectly changing frame clones limit
ClosedPublic

Authored by alvinhochun on Nov 11 2017, 3:09 PM.

Details

Summary

This fixes a bug in commit 4cb8298 (D8193) which added an fps limiting config but incorrectly overrode the frame clones limit config, and in addition the thread count config.

This may or may not fix part of https://bugs.kde.org/show_bug.cgi?id=386620

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alvinhochun created this revision.Nov 11 2017, 3:09 PM
Restricted Application added a subscriber: woltherav. · View Herald TranscriptNov 11 2017, 3:09 PM
neviril added a comment.EditedNov 11 2017, 4:26 PM

I tried to apply the patch (using TortoiseGitMerge) on Krita-master from git, on Windows 10 64bit. I haven't measured the drawing framerate precisely yet, but compared to Krita 3.3.2 official, drawing still feels low fps-ish, even at the default 100 fps limit.

Oh darn, this looks like copy & paste at its worst on my side. Thanks for finding this. I know, I need to look at https://bugs.kde.org/show_bug.cgi?id=386620.

This revision was automatically updated to reflect the committed changes.

I tried to apply the patch (using TortoiseGitMerge) on Krita-master from git, on Windows 10 64bit. I haven't measured the drawing framerate precisely yet, but compared to Krita 3.3.2 official, drawing still feels low fps-ish, even at the default 100 fps limit.

I guess that's not a regression caused by the fps limit config then.