Support modifier+mouse button on window decoration
ClosedPublic

Authored by graesslin on Nov 11 2017, 11:30 AM.

Details

Summary

On X11 modifier+mouse button on the window decoration triggers the
"special" handling thus as unrestricted move instead of passing the click
to the decoration. Of course on Wayland we want to have the same
functionality.

BUG: 386708
FIXED-IN: 5.11.4

Test Plan

New test case added. PointerInputTest still passes.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Nov 11 2017, 11:30 AM
Restricted Application added a project: KWin. · View Herald TranscriptNov 11 2017, 11:30 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Nov 12 2017, 9:58 PM
davidedmundson added a subscriber: davidedmundson.

ship it, but I have a question

input.cpp
960

if we're always going to do:

if (actionResult.first) {
    return actionResult.second;

why return two bools and not just "and" them here?

This revision is now accepted and ready to land.Nov 12 2017, 9:58 PM
graesslin added inline comments.Nov 13 2017, 4:16 PM
input.cpp
960

if actionResult.first is true we should not further process and return the result of actionResult.second. If actionResult.second is false we don't know anymore what the result of actionResult.first was if we and them.

This revision was automatically updated to reflect the committed changes.