Differential D8710

Fix VI-Mode buffer commands
ClosedPublic
Actions

Authored by croick on Nov 8 2017, 12:39 AM.

Details

Reviewers

cullmann

Group Reviewers

KTextEditor

Commits

R39:62e4c17cbc79: Fix VI-Mode buffer commands

Summary

:tabclose currently makes kate crash.
Switching tabs with commands like :bp or :tabp only works once due to loss of focus. The user must click into the view to reactivate it.
Fix crash when switching documents with :b filename

Test Plan

use :tabclose to close a document
switch documents several times with :bp, :tabn, etc.
use :b filename to switch to corresponding tab

Diff Detail

Repository

R39 KTextEditor

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

croick created this revision.Nov 8 2017, 12:39 AM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptNov 8 2017, 12:39 AM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

croick mentioned this in D8712: Extend KTextEditor-plugin integration to activate VI-Mode commands.Nov 8 2017, 12:42 AM

croick mentioned this in R32:d1666b512975: Extend KTextEditor-plugin integration to activate VI-Mode commands.Nov 8 2017, 10:05 PM

The single shots are not that nice, but I understand that they are necessary to defer the action.
Feel free to commit.

This revision is now accepted and ready to land.Nov 12 2017, 2:37 PM

In D8710#166793, @cullmann wrote:

The single shots are not that nice, but I understand that they are necessary to defer the action.

At first I changed the invokeMethod arguments in utils/application.cpp to Qt::QueuedConnection. But then the return values would be meaningless and might actually cause more problems.

Closed by commit R39:62e4c17cbc79: Fix VI-Mode buffer commands (authored by croick). · Explain WhyNov 12 2017, 8:40 PM

This revision was automatically updated to reflect the committed changes.